search

atosatto / ansible-dockerswarm

Docker Engine clustering using "Swarm Mode" and Ansible
https://galaxy.ansible.com/atosatto/docker-swarm/
MIT License
264 stars 148 forks source link

Enable support for Raspberry Pi #77

Open wombathuffer opened 4 years ago

wombathuffer commented 4 years ago

Thanks for refactoring the code - your doing a great job here!

I'm using your role on a pi3, so I have a few modifications, I would ask you to add?

  1. Could you please add armv7l: "arm64" to docker_architechture in vars/main.yml ?

  2. Could you add the following to the bottom of tasks/setup-docker-compose.yml ?

    when: ansible_userspace_architecture is defined 
- block:
- name: Pip install Docker Compose.
pip:
  name: docker-compose
  extra_args: --user
  executable: pip3

when: ansible_userspace_architecture is undefined

    This enables docker compose to be installed via pip on my type device. :)

Thank you!!

atosatto commented 4 years ago

Ehi @wombathuffer I would be more than happy to accept a PR if you don't mind contributing it :)

wombathuffer commented 4 years ago

Ehi @wombathuffer I would be more than happy to accept a PR if you don't mind contributing it :)

I have tried, but either I'm too stupid to do a pull request on your repo, or I lack access.. I'm not that good at gitting...

$ git push origin Raspberry_Pi3_support
Enter passphrase for key '/home/me/.ssh/id_rsa':
ERROR: Permission to atosatto/ansible-dockerswarm.git denied to deploy key
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
darac commented 3 years ago

Hi @wombathuffer, To create a pull request, you need to Fork this repository (which creates your own personal copy of the repository), push your changes to a new branch on your fork and then, on the GitHub page for your repository, create a pull-request (which requests that @atosatto pull the changes from your repository to their repository).

Full details can be found in the GitHub documentation: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/proposing-changes-to-your-work-with-pull-requests