atoum / AtoumBundle

This bundle provides a simple integration of atoum into Symfony 2.
MIT License
44 stars 25 forks source link

Updated Readme #30

Closed romaricdrigon closed 11 years ago

romaricdrigon commented 11 years ago

Hi,

I changed a little bit the installation instructions:

FlorianLB commented 11 years ago

Hi. Thx for this PR but few notices :

added a note about not forgetting atoum in composer.json

Why ? atoum is already required in composer.json of the bundle

I'm not sure the @dev tag exists, so the required version is dev-master

@dev is not a tag, it's a stability flag. But you're right, dev-master is correct and works fine. The @dev is required only on atoum/atoum when your minimum-stability is not set as dev

romaricdrigon commented 11 years ago

Hi,

I've just checked again, composer complains that you need atoum when trying to install only atoum-bundle.

stephpy commented 11 years ago

@romaricdrigon Thank you for this PR.

In composer.json we needs to define atoum too since symfony works (since 2.2) with alpha minimum-stability, but if you replace it by dev, you'll not have to do this. I think it's a good idea do define both on composer.json.

stephpy commented 11 years ago

Thank you ;)

romaricdrigon commented 11 years ago

De nada, that's a great bundle :)

jubianchi commented 11 years ago

@romaricdrigon thanks for your work! nice to see you in here :)