adding hasText method - Githubissues

atoum / AtoumBundle

This bundle provides a simple integration of atoum into Symfony 2.

MIT License

44 stars 25 forks source link

Closed omansour closed 11 years ago

omansour commented 11 years ago

Used to quickly check if a response contain a text

kennydee commented 11 years ago

:+1:

FlorianLB commented 11 years ago

Thx for your PR.

Just few comments :

can you implement the fail message in the same way that other methods ?
i think the name "hasText" can be in conflict with "hasContent". Not easy to see the difference between both. What about "contains"/"containsText" or something like that ?
unit tests would be great if you have time ^^

omansour commented 11 years ago

ok I will do that

stephpy commented 11 years ago

:+1:

omansour commented 11 years ago

still missing time for writing the test ... damnit

FlorianLB commented 11 years ago

Thx ;)