atoum / AtoumBundle

This bundle provides a simple integration of atoum into Symfony 2.
MIT License
45 stars 25 forks source link

removing all replace statements in composer.json #72

Closed fvilpoix closed 9 years ago

fvilpoix commented 10 years ago

Hello,

As the AtoumBundle as been moved to atoum namespace for a long time, I suggest to remove the old "replace" statements, which causes a quiet long delay when doing a composer update with a lot of dependencies.

Here are exemples of my composer update for 2 projects :

[132.5MB/13.67s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$propel1-bridge.json from cache
[133.9MB/14.26s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$proxy-manager-bridge.json from cache
[134.5MB/14.47s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$expression-language.json from cache
[134.7MB/14.55s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$security-acl.json from cache
[135.0MB/14.57s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$security-http.json from cache
[515.4MB/64.98s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-jedi$atoum-bundle.json from cache
[515.4MB/64.98s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-rezzza$atoum-bundle.json from cache
[515.5MB/64.98s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-mageekguy$atoum.json from cache

or in a small project :

[100.9MB/9.01s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$security-acl.json from cache
[101.2MB/9.04s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$security-http.json from cache
[134.5MB/11.16s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$doctrine-abstract-bundle.json from cache
[285.9MB/25.01s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-jedi$atoum-bundle.json from cache
[286.0MB/25.01s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-rezzza$atoum-bundle.json from cache
[286.0MB/25.01s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-mageekguy$atoum.json from cache

Thx :)

FlorianLB commented 10 years ago

:+1:

FlorianLB commented 9 years ago

For the 1.2 ?

ping @jubianchi @stephpy

jubianchi commented 9 years ago

@FlorianLB :+1:

stephpy commented 9 years ago

:+1:

jubianchi commented 9 years ago

I think this branch should be rebased...

fvilpoix commented 9 years ago

@jubianchi done :D

fvilpoix commented 9 years ago

By the way, since the new update on composer, I'm not sure this PR will be very usefull : (on the same exemple that my very first exemple)

[167.1MB/11.47s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-symfony$var-dumper.json from cache
[406.7MB/24.71s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-mageekguy$atoum.json from cache
[407.1MB/24.73s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-jedi$atoum-bundle.json from cache
[407.1MB/24.74s] Reading /Users/fvilpoix/.composer/cache/repo/https---packagist.org/provider-rezzza$atoum-bundle.json from cache

13s instead of 50s.

However, maybe the "replace": {"mageekguy/atoum": "*"} from atoum will keep the calculation delay...

jubianchi commented 9 years ago

@fvilpoix Thanks!

The replace on atoum should stay here, it seems that many repositories depends on the old name: https://github.com/search?utf8=%E2%9C%93&q=%22mageekguy%2Fatoum%22%3A+%22+extension%3Ajson&type=Code&ref=advsearch&l=

fvilpoix commented 9 years ago

of course !

FlorianLB commented 9 years ago

Thx buddy !