search

atoum / AtoumBundle

This bundle provides a simple integration of atoum into Symfony 2.
MIT License
44 stars 25 forks source link

Symfony3 compatibility #91

Closed FlorianLB closed 8 years ago

FlorianLB commented 8 years ago

Symfony\Component\DomCrawler\Crawler changes in 3.0 : it doesn't implement anymore \SplObjectStorage so we can't rely anymore on contains method in our tests.

I don't really know this component, if someone have a better idea.. ? ping @jubianchi

aliel commented 8 years ago

You can use "in_array" function instead of "contains" and it looks like this

->array(iterator_to_array($children))
  ->contains($child)

with a performance issue ?

https://github.com/aliel/AtoumBundle/commit/d8a0ae92d6aca2e2040b1d38963a3f1ac2c945a9

cedvan commented 8 years ago

:+1:

cedvan commented 8 years ago

merge possible ?

jubianchi commented 8 years ago

If everybody is OK, I'll merge this tomorrow and issue an new release.

cedvan commented 8 years ago

@jubianchi ok for me :)

aliel commented 8 years ago

OK

cedvan commented 8 years ago

Up please ?

FlorianLB commented 8 years ago

https://github.com/atoum/AtoumBundle/releases/tag/1.4.0