Chaining multiple hasConstant assertions fails

[jubianchi]

Example:

<?php

namespace atoum\shou\tests\units;

use atoum;

class runner extends atoum
{
    public function testClass()
    {
        $this
            ->testedClass
                ->hasConstant('runStart')->isEqualTo('runnerStart')
                ->hasConstant('runStop')->isEqualTo('runnerStop')

                ->extends('atoum\shou\observable')
                ->implements('atoum\shou\observer')
        ;
    }
} 

This produces the following error:

 There is 1 error:
=> atoum\shou\tests\units\runner::testClass():
==> Error E_USER_ERROR in /Users/julien.bianchi/repositories/atoum/shou/tests/units/classes/runner.php on line 14, generated by file /Users/julien.bianchi/repositories/atoum/shou/tests/units/classes/runner.php on line 14:
Asserter 'hasConstant' does not exist

If I comment the second hasConstant assertion, I get the following error:

> There is 1 error:
=> atoum\shou\tests\units\runner::testClass():
==> Error E_USER_ERROR in /Users/julien.bianchi/repositories/atoum/shou/tests/units/classes/runner.php on line 16, generated by file /Users/julien.bianchi/repositories/atoum/shou/tests/units/classes/runner.php on line 16:
Asserter 'extends' does not exist

BTW, there is a workaround:

<?php

namespace atoum\shou\tests\units;

use atoum;

class runner extends atoum
{
    public function testClass()
    {
        $this
            ->testedClass
                ->hasConstant('runStart')->isEqualTo('runnerStart')
            ->testedClass
                ->hasConstant('runStop')->isEqualTo('runnerStop')
            ->testedClass
                ->extends('atoum\shou\observable')
                ->implements('atoum\shou\observer')
        ;
    }
} 

[Hywan]

Is it a bug? What about other asserters of the same group/family?

[jubianchi]

@Hywan as we discussed on IRC, this is a bug but we won't fix it because:

• it will add too much complexity to the asserter's code
• it will probably produce side effects on the asserter
• it will make the asserter too tightly coupled too the testedClass asserter

This is a won't fix... I think

[mageekguy]

It's not a bug, it's a feature… More seriously, this behavior is the wanted behavior, because any other implementation/solution is too complex regards to value added.

[Hywan]

Did other asserters behave like this also?

[jubianchi]

@Hywan some asserters are chainable, some other (like hasConstant) are not.

[Hywan]

Is it a lack of consistency?

[jubianchi]

@Hywan nop, it's a choice made to KISS see https://github.com/atoum/atoum/issues/388#issuecomment-66607966 and https://github.com/atoum/atoum/issues/388#issuecomment-66611281

[Hywan]

Thanks :-).