search

atoum / json-schema-extension

The atoum json-schema-extension allows you to validate JSON against schemas.
Other
8 stars 4 forks source link

Fix assertions not reported #17

Closed shouze closed 7 years ago

shouze commented 7 years ago

running tests with this extension, I got atoum reports with void methods and zero assertions whilst I expected non void & assertions reported.

Note: we can patch both v1 & v2 if we want to maintain v1.

shouze commented 7 years ago

@Hywan so, with the latest commit (trusty upgrade on ci) looks like prefer-lowest ALWAYS leads to the infinite loop issue https://github.com/atoum/json-schema-extension/pull/16#issuecomment-325683054

shouze commented 7 years ago

Ok launched ci few times and in fact... no, it's truly random.

Hywan commented 7 years ago

@shouze I don't have time to check this issue. Please, see with @jubianchi :-).

shouze commented 7 years ago

@Hywan ok no problem, in fact it's more a lot of commits that I can probably pass in separate PRs I guess.

jubianchi commented 7 years ago

@shouze @Hywan I'm planning to issue some release today or tomorrow. I'll start with atoum and then review and merge PRs on extensions.

shouze commented 7 years ago

@jubianchi will be available to split in more PRs if needed.

jubianchi commented 7 years ago

@shouze don’t worry it’s fine without splitting.

But it would be awesome if you could dd the missing entries to the changelog.

Thanks!

shouze commented 7 years ago

Yes of course, miss tests for notValidates too.

shouze commented 7 years ago

ok @jubianchi so I've added notValidates tests & CHANGELOG entries, ready for a review, just that infinite loop that blocks ci randomly but everything is green otherwise.

shouze commented 7 years ago

ping @jubianchi when you have a minute or two 👼