search

atoum / ruler-extension

The atoum ruler-extension allows you to filter your tests using Hoa\Ruler.
MIT License
9 stars 4 forks source link

Fix minimum version on dependancies #22

Closed agallou closed 8 years ago

agallou commented 8 years ago

We need at least atoum/atoum. version 1.0. Without that we'll get this error :

PHP Fatal error:  Call to undefined method mageekguy\atoum\runner::addExtension() in /home/agallou/Projets/atoum-hoa-ruler/.atoum.php on line 7

We need at least hoa/ruler 1.15.11.09. Without that we'll get this error :

Call to undefined method Hoa\Ruler\Ruler::interpret()

We need at least hoa/regex 0.15.05.29. Without that, we'll get this error :

UnexpectedValueException' with message 'RecursiveDirectoryIterator::__construct(/home/agallou/Projets/atoum-hoa-ruler/vendor/hoa/ustring/): failed to open dir: No such file or directory'

And finally, we need hoa/core 2.14.12.10. otherwise this happens :

Hoa\File\File::_open(): (1) Failed to open stream hoa://Library/Ruler/Grammar.pp.

This errors (which can be reproduced by a composer update --prefer-lowest && ./vendor/bin/atoum), can be fixed by setting the minimum dependancies in the composer.json.

@Hywan this should not be defined in a projet that requires hoa/ruler. There may be something to do on that on hoa.

Hywan commented 8 years ago

@agallou About Hoa\Ruler, yes you need at least 1.15.11.09. You don't need any specific version for Hoa\Regex I guess… except 0.15.05.29 to be compatible with PHP7. And yes, there was a bug with Composer's autoloader that has been fixed in Hoa\Core 2.14.12.10.

I don't understand what you mean by “There may be something to do on that on Hoa”. Can you clarify please?

agallou commented 8 years ago

@Hywan without those specific versions of hoa/regex et hoa/core, the tests are failing with the errors in the PR description. So we need a least hoa/regex 0.15.05.29 and hoa/core 2.14.12.10.

What a meant with "There may be something to do on that on Hoa" is that when I require hoa/ruler with the lowest dependancies versions, I should not have to manually add minimum versions for hoa/ruler dependancies. They should be defined on hoa librairies.

Hywan commented 8 years ago

@agallou Hmm, can you open an issue on https://github.com/hoaproject/Central please? This is more appropriated for such a discussion :-).