search

atoum / ruler-extension

The atoum ruler-extension allows you to filter your tests using Hoa\Ruler.
MIT License
9 stars 4 forks source link

Update Hoa's dependencies #29

Closed Hywan closed 8 years ago

Hywan commented 8 years ago

Replace https://github.com/atoum/ruler-extension/pull/28.

Hoa\Core has been removed while dropping PHP5.4. Bump all versions!

jubianchi commented 8 years ago

see https://github.com/atoum/ruler-extension/pull/28#issuecomment-170508408

agallou commented 8 years ago

is there a way to detect hoa's version ?

atoum works on php 5.3, I think it will be better to try to keep the same minimum version for the extensions as atoum's.

Does this work ?

Hywan commented 8 years ago

@agallou The minimum required PHP version is stored in hoa/consistency: https://github.com/hoaproject/Consistency/blob/c7919e409ca68858f8cceadb7565b9f622575249/composer.json#L25.

There is no mechanism to detect “Hoa's version” since it is no a monolothic piece of code. This is a set of different living projects (libraries).

We can maintain several branches if you don't want to drop PHP5.3 and 5.4 support.

agallou commented 8 years ago

in the autoload, if the is_file on Hoa/Core return false, we can try to load the prelude file in consistency ? (an then add the hoa/core directory according to the loaded file).

This version doesn't add new feature to the users ? so let's try to keep the compatibility with the same version of PHP (until atoum moves forward it's required php version)

Hywan commented 8 years ago

@agallou It adds 5 new libraries that we are already using as a drop replacement of hoa/core, so your proposal is not possible :-/.

agallou commented 8 years ago

ok. So let's update the extension's major version.

Hywan commented 8 years ago

@agallou With specific branches, we could target specific PHP versions though.

jubianchi commented 8 years ago

@agallou with good version constraint on the extension (i.e atoum/ruler-extension: @stable) composer will nicely handle everything ;)

Hywan commented 8 years ago

ping?

Hywan commented 8 years ago

ping :-)?

jubianchi commented 8 years ago

@Hywan will be done tonight ;) sorry fir the delay

jubianchi commented 8 years ago

@Hywan I can't merge this PR as a composer install (from a clear working dir: no composer.lock and no vendor dir) does not work:

Loading composer repositories with package information
Installing dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package hoa/stream could not be found in any version, there may be a typo in the package name.
  Problem 2
    - hoa/ruler 2.16.01.14 requires hoa/file ~1.0 -> satisfiable by hoa/file[1.16.01.14, 1.16.01.15].
    - hoa/ruler 2.16.01.15 requires hoa/file ~1.0 -> satisfiable by hoa/file[1.16.01.14, 1.16.01.15].
    - hoa/ruler 2.16.01.11 requires hoa/file ~0.0 -> satisfiable by hoa/file[0.14.09.16, 0.14.09.17, 0.14.09.23, 0.14.11.09, 0.14.11.26, 0.14.12.10, 0.15.02.19, 0.15.05.12, 0.15.05.27, 0.15.11.09].
    - hoa/file 1.16.01.15 requires hoa/stream ~1.0 -> no matching package found.
    - hoa/file 1.16.01.14 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.15.11.09 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.15.05.27 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.15.05.12 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.15.02.19 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.14.12.10 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.14.11.26 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.14.11.09 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.14.09.23 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.14.09.17 requires hoa/stream ~0.0 -> no matching package found.
    - hoa/file 0.14.09.16 requires hoa/stream ~0.0 -> no matching package found.
    - Installation request for hoa/ruler >=2.16.01.11,<3.0 -> satisfiable by hoa/ruler[2.16.01.11, 2.16.01.14, 2.16.01.15].

Please, can you fix that ?

jubianchi commented 8 years ago

@Hywan FYI, removing the dependency on hoa/stream fixes the issue with composer.

jubianchi commented 8 years ago

Closing this PR in favor of #30 which has the advantage of not introducing any BC break (5.4 is still supported): thanks to a new constraint, composer will gracefully handle the switch.

Hywan commented 8 years ago

@jubianchi I added hoa/stream because it appeared to be necessary for Composer (don't know why, ask @agallou with the inital trick). Anyway, thanks for your work!!