atperry7 / pup_gearswap

A work in progress gearswap for windower.
https://www.ffxiah.com/forum/topic/53071/pup-gearswap-testers-needed/
11 stars 12 forks source link

Mage Set Swaps In Then Immediately Swaps to Pet TP Set On Deploy #16

Open Gojito opened 3 years ago

Gojito commented 3 years ago

On every first Deploy when the automaton immediately casts, I am seeing that the mage set is equipped, but is immediately swapping to the TP set even though casting hasn't finished. I've tried cycling through all Pet Styles (tried MB mode first), Idle Mode, Offense Mode, and Physical Modes, but the issue persists.

Every cast afterward is fine when the pet is still deployed. However, this affects situations where you want to deploy the pet during MB windows.

When enabling showswaps, I am seeing that pet_midcast is being equipped followed immediately by pet_status_change. I think this is what is causing for the TP gear to be swapped in after starting to cast on Deploy.

atperry7 commented 3 years ago

I see what you mean. Since it happens on the first deploy I think the true culprit is in the job_precast as there is logic present towards the bottom where we don't do any type of check on the PetMode or PetStyle.

It just simply swaps in the TP gear if the pet is valid and has TP.

A quick solution would be to remove that section. I will look at this in more detail this weekend.

PUP-LIB.lua

function job_precast(spell, action, spellMap, eventArgs)
    if spell.english == "Activate" or spell.english == "Deus Ex Automata" then
        TotalSCalc()
        determinePuppetType()
    elseif string.find(spell.english, "Maneuver") then
        equip(sets.precast.JA.Maneuver)
    elseif sets.precast.JA[spell.english] then
        equip(sets.precast.JA[spell.english])
    elseif sets.precast.WS[spell.english] then
        equip(sets.precast.WS[spell.english])
    elseif pet.isvalid then
        if spell.english == "Deploy" and pet.tp >= 950 then <--------------------------- Culprit Swapping TP Gear
            equip(sets.midcast.Pet.WSNoFTP)
            eventArgs.handled = true
        end <------------------------------ End of Culprit
    end
end
spacegoatwrangler commented 3 years ago

Any update on this issue?

Gojito commented 3 years ago

I ended up making an idle set I can cycle into that equips the mage set. Not the cleanest solution but works.

spacegoatwrangler commented 3 years ago

Any chance you could send me an example of what you did? ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Wednesday, June 23rd, 2021 at 12:32 AM, gmorales @.***> wrote:

I ended up making an idle set I can cycle into that equips the mage set. Not the cleanest solution but works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.