off-by-one in http.go - Githubissues

atredispartners / flamingo

Flamingo captures credentials sprayed across the network by various IT and security products.

BSD 2-Clause "Simplified" License

451 stars 50 forks source link

off-by-one in http.go #9

Closed theguly closed 4 years ago

theguly commented 4 years ago

hi there, i feel there's a bug in ./pkg/flamingo/http.go line 323: nt := v2[32 : len(v2)-1]

doesn't it truncate NTLM hash to 31chars?

hdm commented 4 years ago

good catch, this is broken in a few more ways as well

hdm commented 4 years ago

the lm truncation was fixed, but we opened #10 to handle the remaining issues with ntlm. the reported ntlm hash is a long blob of the ntlmssp data and it doesn't look right.