de-robat
commented
8 years ago Hello @johnbrett ,
Basically I did remove everything which was related to hot replacement when I implemented this plugin. That’s not because hot replacement isn't an awesome feature, but because I had some time constraints to get it up and running for a project and simple reloading was sufficient. I’m glad you want to implement this feature and would love to be of the best assistance I could be at this moment.
The hapi plugin is based on the original webpack-dev-middleware for express https://github.com/webpack/webpack-dev-server . Now i just adapted the express way to the hapi way. It consist of two parts, first of all the Server-Side which compiles and delivers, and second of all the Client-Side which host the frame app an manages every kind of reloading. As far as I can see, the difference between hot-replacement and app reloading is only the way code is injected into the Client-Side.
If you check the original project here is how it maps to the hapi plugin:
The backend
- /lib ^= /src
- /lib/Server.js ^= /src/plugin.js and /src/pluginutil.js --> so here you find everything which deals with the compilation and here you would have to check for all the places where the "hot" option is used in the original webpack-dev-middleware and reintroduce them to the hapi plugin
The frontend
- The client directory maps almost 1 to 1 to the plugins client directory - i did not change too much here it should still support the hot replacement mode
As far as I can understand the missing piece to integrate is: https://github.com/glenjamin/webpack-hot-middleware (well after it's converted to hapi)
From my point of view you don't need this. This seems to be simply for integrating the webpack-hot-replacment into an existing express server as it states:
... This allows you to add hot reloading into an existing server without webpack-dev-server.
All you'd have to do is: enable the hot mode again, sending the "hot" message to the client and check if everything flows as it is intended to :)
You can fork this repo and start working on it, if you get stuck just text me and i'll have a look at your fork,
johnbrett
legomind
yotamberk
Hey @atroo, great work on this plugin.
I'm trying to get hot loading working with it, to create something like: https://github.com/gaearon/react-transform-boilerplate
As far as I can understand the missing piece to integrate is: https://github.com/glenjamin/webpack-hot-middleware (well after it's converted to hapi)
Any advice on where to start with this, or have you made much progress yourself ??