Closed atrovato closed 1 year ago
Merging #18 (52ad3a1) into master (dc25cf7) will increase coverage by
0.85%
. The diff coverage is98.66%
.
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 95.59% 96.44% +0.85%
==========================================
Files 532 673 +141
Lines 7189 8657 +1468
==========================================
+ Hits 6872 8349 +1477
+ Misses 317 308 -9
Impacted Files | Coverage Δ | |
---|---|---|
server/api/controllers/weather.controller.js | 100.00% <ø> (ø) |
|
server/config/config.js | 100.00% <ø> (ø) |
|
server/lib/device/device.saveStringState.js | 100.00% <ø> (ø) |
|
server/lib/scene/scene.get.js | 100.00% <ø> (ø) |
|
server/lib/user/user.getById.js | 100.00% <ø> (ø) |
|
server/models/scene.js | 93.75% <ø> (ø) |
|
server/seeders/20190227081700-device-feature.js | 100.00% <ø> (ø) |
|
server/services/usb/api/usb.controller.js | 100.00% <ø> (ø) |
|
server/services/tasmota/lib/features/infrared.js | 40.00% <40.00%> (ø) |
|
...er/services/tasmota/lib/features/radioFrequency.js | 40.00% <40.00%> (ø) |
|
... and 203 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5725b5b...52ad3a1. Read the comment docs.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!