Closed atrovato closed 2 years ago
Merging #20 (5e976b2) into television-device (c287790) will increase coverage by
0.10%
. The diff coverage is100.00%
.:exclamation: Current head 5e976b2 differs from pull request most recent head ea09675. Consider uploading reports for the commit ea09675 to get more accurate results
@@ Coverage Diff @@
## television-device #20 +/- ##
=====================================================
+ Coverage 96.54% 96.64% +0.10%
=====================================================
Files 613 695 +82
Lines 8735 8865 +130
=====================================================
+ Hits 8433 8568 +135
+ Misses 302 297 -5
Impacted Files | Coverage Δ | |
---|---|---|
server/utils/constants.js | 100.00% <ø> (ø) |
|
...ver/services/broadlink/api/broadlink.controller.js | 100.00% <100.00%> (ø) |
|
server/services/broadlink/index.js | 100.00% <100.00%> (ø) |
|
...broadlink/lib/commands/broadlink.getPeripherals.js | 100.00% <100.00%> (ø) |
|
.../services/broadlink/lib/commands/broadlink.init.js | 100.00% <100.00%> (ø) |
|
...vices/broadlink/lib/commands/broadlink.setValue.js | 100.00% <100.00%> (ø) |
|
.../services/broadlink/lib/commands/broadlink.stop.js | 100.00% <100.00%> (ø) |
|
...es/broadlink/lib/events/broadlink.addPeripheral.js | 100.00% <100.00%> (ø) |
|
server/services/broadlink/lib/index.js | 100.00% <100.00%> (ø) |
|
...vices/broadlink/lib/learn/broadlink.cancelLearn.js | 100.00% <100.00%> (ø) |
|
... and 163 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c287790...ea09675. Read the comment docs.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!