Closed atrovato closed 1 year ago
Merging #65 (3d2ffc8) into master (102d327) will decrease coverage by
0.02%
. The diff coverage isn/a
.:exclamation: Current head 3d2ffc8 differs from pull request most recent head b974303. Consider uploading reports for the commit b974303 to get more accurate results
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 97.28% 97.27% -0.02%
==========================================
Files 645 643 -2
Lines 9724 9686 -38
==========================================
- Hits 9460 9422 -38
Misses 264 264
Impacted Files | Coverage Δ | |
---|---|---|
server/api/controllers/gateway.controller.js | 60.00% <0.00%> (-2.97%) |
:arrow_down: |
server/services/mqtt/lib/installContainer.js | 97.05% <0.00%> (-0.17%) |
:arrow_down: |
server/api/routes.js | 98.03% <0.00%> (ø) |
|
server/models/dashboard.js | 100.00% <0.00%> (ø) |
|
server/utils/httpErrors.js | 100.00% <0.00%> (ø) |
|
server/lib/gateway/index.js | 100.00% <0.00%> (ø) |
|
server/lib/dashboard/index.js | 100.00% <0.00%> (ø) |
|
server/lib/dashboard/dashboard.get.js | 100.00% <0.00%> (ø) |
|
server/lib/dashboard/dashboard.create.js | 100.00% <0.00%> (ø) |
|
server/services/mqtt/lib/updateContainer.js | 100.00% <0.00%> (ø) |
|
... and 4 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!