Broadlink tv volume previous next

atrovato commented 1 year ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

[ ] If your changes affects code, did your write the tests?
[ ] Are tests passing? (npm test on both front/server)
[ ] Is the linter passing? (npm run eslint on both front/server)
[ ] Did you run prettier? (npm run prettier on both front/server)
[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
[ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`4508908`
Status:	⚡️ Build in progress...

View logs

codecov[bot] commented 1 year ago

Codecov Report

Merging #91 (4eef07d) into master (e313b82) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   97.58%   97.63%   +0.05%     
==========================================
  Files         662      678      +16     
  Lines       10053    10287     +234     
==========================================
+ Hits         9810    10044     +234     
  Misses        243      243

Impacted Files	Coverage Δ
server/utils/constants.js	`100.00% <ø> (ø)`
...roadlink/lib/commands/features/broadlink.remote.js	`100.00% <100.00%> (ø)`
server/services/index.js	`100.00% <100.00%> (ø)`
...services/lan-manager/api/lan-manager.controller.js	`100.00% <100.00%> (ø)`
server/services/lan-manager/index.js	`100.00% <100.00%> (ø)`
server/services/lan-manager/lib/index.js	`100.00% <100.00%> (ø)`
.../services/lan-manager/lib/lan-manager.constants.js	`100.00% <100.00%> (ø)`
...es/lan-manager/lib/lan-manager.getConfiguration.js	`100.00% <100.00%> (ø)`
...an-manager/lib/lan-manager.getDiscoveredDevices.js	`100.00% <100.00%> (ø)`
.../services/lan-manager/lib/lan-manager.getStatus.js	`100.00% <100.00%> (ø)`
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #91 (3a753c4) into master (bfd5668) will decrease coverage by 0.14%. The diff coverage is 100.00%.

:exclamation: Current head 3a753c4 differs from pull request most recent head b71f219. Consider uploading reports for the commit b71f219 to get more accurate results

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   97.79%   97.65%   -0.14%     
==========================================
  Files         702      678      -24     
  Lines       10852    10338     -514     
==========================================
- Hits        10613    10096     -517     
- Misses        239      242       +3

Impacted Files	Coverage Δ
server/utils/constants.js	`100.00% <ø> (ø)`
...roadlink/lib/commands/features/broadlink.remote.js	`100.00% <100.00%> (ø)`

... and 53 files with indirect coverage changes

atrovato / Gladys