search

atsa-es / marssTMB

Companion package for MARSS that allows you to use TMB to fit MARSS models
https://atsa-es.github.io/marssTMB/
1 stars 0 forks source link

Covar #2

Closed ericward-noaa closed 1 year ago

ericward-noaa commented 1 year ago

Added some more examples w/covariates in the vignettes, and cleaned up some of the Description issues. Also minimal tests for benchmarking

eeholmes commented 1 year ago

Check out the MARSStmb.R function. Seems to be working. Note I have not changed the dfa.hpp code at all. Also I have not tested covariates. Just working on getting the MARSS integration set up. Once that is done, then all the MARSS helper functions (coef, printing, plotting, residuals) should work.

ericward-noaa commented 1 year ago

My initial commit moved them, but I moved them back. These don't show up on the file diffs, so I think it's ok:

https://github.com/atsa-es/marssTMB/pull/2/files

The changes here are (1) including some examples with covariates in the vignettes, (2) adding tests (3) tweaking Description / commenting in docs

ericward-noaa commented 1 year ago

I also added the .o and .so files to .gitignore, so these can probably be removed

eeholmes commented 1 year ago

I merged in the changes. Questions re the .o and .so files. Are those regenerated each time one installs pkg? Should I delete on GitHub?

ericward-noaa commented 1 year ago

Yeah - this are generated by the compiler from either the cpp or hpp files. They’re compiler specific - so will be autogenerated when someone installs (I think this is what was causing my compiler issues)

On Mon, May 1, 2023 at 5:29 PM Eli Holmes - NOAA @.***> wrote:

I merged in the changes. Questions re the .o and .so files. Are those regenerated each time one installs pkg? Should I delete on GitHub?

— Reply to this email directly, view it on GitHub https://github.com/atsa-es/marssTMB/pull/2#issuecomment-1529837481, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGQEZDRX7QA44GHEHAFFB3XD7JFVANCNFSM6AAAAAAXRCCQAE . You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from my iPhone