atsam-rs / atsam4-hal

Apache License 2.0
5 stars 3 forks source link

ChipId architecture enum doesn't include some Sam4S variants. #37

Closed john-terrell closed 3 years ago

john-terrell commented 3 years ago

The data sheet only document three 4S variants. The missing variants are the SAM4SDx.

haata commented 3 years ago

D represents dual flash, so likely we can use the 2nd flash bank.

See: https://github.com/kiibohd/controller/blob/master/Lib/chip_version.h#L178

haata commented 3 years ago

Technically atsam4s16b and atsam4sa16b are different chips as well. (difference is cache unit)

john-terrell commented 3 years ago

I have updated the PR for this to include family and model fields that correspond to the actual models.