atsams-rs / atsamx7x-rust

Rust HAL, PACs, and examples for the Microship SAM E70/S70/V70/V71
Apache License 2.0
24 stars 11 forks source link

[Fixes #62] Remove re-exports to avoid warnings promoted to errors #64

Closed michalfita closed 8 months ago

michalfita commented 9 months ago

Purpose

My rustc 1.72.0 started to spit warnings at me, and CI fails on workflows with disabled minimum compiler version to be used (as 1.63.0 seems to be unaffected).

Scope

Alternative

The alternative is to rename types to be more peripheral type specific. I have feeling at the moment we have mixture of both simple names in namespaces and specifically named peripherals despite being in namespaces.

michalfita commented 9 months ago

I cannot remove #![deny(const_err)] at the moment as it comes from PACs generation. The problem will solve itself when #61 is merged.

michalfita commented 8 months ago

This looks good to me, although it feels like the CI is slowly growing more and more unruly and there should be a better way to do this.

We could extend the matrix but the Rust Version component, but I don't have will power ATM to do this, but it would keep jobs definition flatter. Raise an issue if you prefer that way, @martinmortsell, and in future we may address this - now I'm aiming at making a release with separated PACs.