search

atsb / Doom64EX-Plus

An improved modern version of Doom64EX.
GNU General Public License v2.0
100 stars 16 forks source link

"Apply Settings" in video settings menu does nothing #225

Open Candlemass opened 4 months ago

Candlemass commented 4 months ago

Hello, I recently tried Doom 64 EX Plus after using the standard Doom 64 EX for years well before the bethesda remake. Anyway, after trying the port I realized that the "apply settings" option in the video settings menu doesn't do anything and in order for the changes to take effect the game has to be manually closed and restarted.

bubbleguuum commented 4 months ago

Looking at the code it seems to be designed in a way that changing the resolution parameters and window type do require to restart the game. I suppose that if it cannot be changed to be applied without restart, hitting 'Apply' could display a message about restarting the game.

Candlemass commented 4 months ago

That would be helpful if a code rewrite is too cumbersome. In all honesty this isn't that big of a deal but since it wasn't functioning as one is lead to believe it should be based on the wording, I figured it would be worth creating a ticket for.

atsb commented 4 months ago

Yeah I am going to start the renderer again once this happens, so I will be changing this. I'll close it once it is done.