Closed darthtrevino closed 9 years ago
Looks good. I love mocha - makes that sort of test so easy.
Mocha is great! We're also using supertest to directly test the express app object's responses https://github.com/visionmedia/supertest
You should put a Promise example in the readme. I think proxies are a good compromise on the seam - no forced dependency, but the power to convert your middleware as needed. Means you can mix and match middleware types too, so you can pull in other libs that may not be promisified.
It may be worthwhile to capture some common proxies that we consider to be useful and store them in a 'proxies' folder. Then clients could use require('express-jefferson/promise-proxy')
:+1: to boilerplate proxies
I think this PR is about ready to roll. When travis gives me the greenlight I'll merge it.