atsid / express-jefferson

Declarative Application Routing
Apache License 2.0
4 stars 1 forks source link

Adding a 'proxies' section to the Jefferson configuration #2

Closed darthtrevino closed 9 years ago

darthtrevino commented 9 years ago
natoverse commented 9 years ago

Looks good. I love mocha - makes that sort of test so easy.

darthtrevino commented 9 years ago

Mocha is great! We're also using supertest to directly test the express app object's responses https://github.com/visionmedia/supertest

natoverse commented 9 years ago

You should put a Promise example in the readme. I think proxies are a good compromise on the seam - no forced dependency, but the power to convert your middleware as needed. Means you can mix and match middleware types too, so you can pull in other libs that may not be promisified.

darthtrevino commented 9 years ago

It may be worthwhile to capture some common proxies that we consider to be useful and store them in a 'proxies' folder. Then clients could use require('express-jefferson/promise-proxy')

natoverse commented 9 years ago

:+1: to boilerplate proxies

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-3.23%) to 96.77% when pulling ab37dfb5c2a4cdc9dfb1927c353f3a09012259ac on 1-proxies into a19da5ac19ea49c4474a8cf24db4fc599a69c001 on master.

darthtrevino commented 9 years ago

I think this PR is about ready to roll. When travis gives me the greenlight I'll merge it.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 40a4979d6c4a862f9144ebedb3166a3c3a40cc1c on 1-proxies into a19da5ac19ea49c4474a8cf24db4fc599a69c001 on master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 40a4979d6c4a862f9144ebedb3166a3c3a40cc1c on 1-proxies into a19da5ac19ea49c4474a8cf24db4fc599a69c001 on master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 40a4979d6c4a862f9144ebedb3166a3c3a40cc1c on 1-proxies into a19da5ac19ea49c4474a8cf24db4fc599a69c001 on master.