search

atsid / guides

Docs and discussion about ATS software delivery culture and practices.
http://labs.atsid.com/guides/
Apache License 2.0
6 stars 4 forks source link

Update README.md #18

Closed Chris-Gillis closed 8 years ago

Chris-Gillis commented 8 years ago

I'm not certain if the intent for this message is to create a fork under your own github account or create a branch in the ATS repo and create the PR from their.

I believe the former to be correct, and if so I propose this word change.

natoverse commented 8 years ago

I could go either way on this myself - either (a) fork the repo personally, make changes, and PR, or (b) make a branch in the main repo, make changes, and PR. We delete branches as soon as the PR is merged, so I'm not concerned about accumulation if (b) is used.

Anyway, either way the wording should be more clear because "branch the repo" sounds like forking. But which mechanism is used I'd recommend leaving up to individual devs based on personal preference. Maybe reword to "fork the repo or create a branch"?

Chris-Gillis commented 8 years ago

That works for me @natoverse!

Chris-Gillis commented 8 years ago

Interesting, the Travis build failed during "gulp deploy".

Anyway I'll close this for now.

natoverse commented 8 years ago

Hmm, looks like the auth failed. I thought the travis config should only try to run the gulp deploy on master commits anyway, so it shouldn't even have tried. I'll update the wording on master and see if it fails again there.