search

atsid / guides

Docs and discussion about ATS software delivery culture and practices.
http://labs.atsid.com/guides/
Apache License 2.0
6 stars 4 forks source link

Fix travis build so it only publishes master #20

Closed natoverse closed 8 years ago

natoverse commented 8 years ago

The branches: master config is apparently not working - my last PR got published to gh-pages automatically, but should not have done so until merge to master.

natoverse commented 8 years ago

I fixed this by simply turning off PR builds on Travis. If we end up with any code that requires quality checks to run, we can use some of the solutions discussed on these pages:

http://docs.travis-ci.com/user/pull-requests/ http://stackoverflow.com/questions/21076678/disable-travis-ci-for-pull-requests

The issue wasn't that branches:master doesn't work - travis was not incorrectly building branches. The issue is that PRs are a merge-master locally on travis, which means the branches:master config doesn't apply.

rickleegit commented 8 years ago

Hey man. Sadly, you should probably drop my account front the GitHub repos.

On Sep 18, 2015, at 7:35 PM, Nathan Evans notifications@github.com wrote:

Closed #20.

— Reply to this email directly or view it on GitHub.