atsign-foundation / at_c

Experimental cross-platform C implementation of the atSDK for SOC & embedded devices
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Functional tests fail on Dependabot PRs as atKey secrets aren't available. #230

Closed cpswan closed 2 weeks ago

cpswan commented 3 weeks ago

Describe the bug

Runs such as https://github.com/atsign-foundation/at_c/actions/runs/8983193176/job/24672600212 fail because the atKeys are empty because secrets aren't available to Dependabot.

Steps to reproduce

  1. First Dependabot raises a PR
  2. Then tests run
  3. And then functional tests fail

Expected behavior

Tests should pass (or be bypassed where it isn't safe for secrets to be available)

JeremyTubongbanua commented 2 weeks ago

I added the atkeys secrets to the dependabot repository secrets

Close this ticket if Dependabot PRs no longer cause functional tests to fail

cpswan commented 2 weeks ago

268 seems to suggest that we're fine. Thanks @JeremyTubongbanua