at_c: `message_type` and `message_body` from `monitor.c` `static int parse_message` function point to a freed address

[realvarx]

The static parse_message function in monitor.c returns message_type and message_body pointers that point to memory that is freed at the end of the function. This function creates a copy of the original parameter using strdup, which internally uses malloc to allocate memory. However, the function then frees this allocated memory (original_copy) before returning, leaving message_type and message_body pointing to invalid memory.

https://github.com/atsign-foundation/at_c/blob/aaf943db9c9de6b28b64ebdf9903928401ef793a/packages/atclient/src/monitor.c#L247

The solution would involve returning to the old approach (use original parameter, and free it outside of the method after doing memcpy of the type and body), or removing the free(original_copy) from the exit of the method (which could lead to a memory leak if not handled properly later).

[JeremyTubongbanua]

I think I see see what is happening here

Since original_copy is being freed, message_type and message_body are pointers to characters in the original_copy string. Is that correct?

[JeremyTubongbanua]

Assigned 2 SP

[realvarx]

I think I see see what is happening here

Since original_copy is being freed, message_type and message_body are pointers to characters in the original_copy string. Is that correct?

Exactly

[JeremyTubongbanua]

Fix for this in #400