feat: enhance EnrollmentService.fetchEnrollmentRequests() to filter enrollment requests - Githubissues

atsign-foundation / at_client_sdk

The Dart implementation of atSDK used for implementing Atsign's technology into other software

https://pub.dev/publishers/atsign.org/packages

BSD 3-Clause "New" or "Revised" License

1.47k stars 32 forks source link

feat: enhance EnrollmentService.fetchEnrollmentRequests() to filter enrollment requests #1263

Closed srieteja closed 3 months ago

srieteja commented 3 months ago

- What I did

introduce new param 'enrollmentStatusFilter' in EnrollListRequestParam class
use the above param in EnrollmentService.fetchEnrollmentRequests() to build the command that lists only enrollment requests that match the filter.

- How I did it

EnrollListRequestParam.enrollmentStatusFilter will be used by users to pass the desired enrollment statuses they wish to list.
EnrollmentService.fetchEnrollmentRequests() will use this filter to construct a relevant command which will be passed to the server.

- How to verify it

unit test added, that verifies that appropriate command is generated using the EnrollVerbBuilder and the parsing of response from the server.
Yet to evaluate if a functional test is needed to validate the change

- Description for the changelog

feat: enhance EnrollmentService.fetchEnrollmentRequests() to filter enrollment requests

srieteja commented 3 months ago

closing this PR due to incorrect origin