end2end test failure in collection test

[murali-shris]

Describe the bug

https://github.com/atsign-foundation/at_client_sdk/actions/runs/8373572103/job/22927728963 Model operations - unshare() and delete() test fails in github actions

Steps to reproduce

• run the test pointing to local server Getting a different error in local . I think keys retrieval is happening before share/save completes test/collection_test.dart 356:5 main.

  Expected: ['@colin🛠']
  Actual: []
  Which: at location [0] is [] which shorter than expected

  Expected behavior

test should pass

Screenshots

No response

Smartphones

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Were you using an atApplication when the bug was found?

No response

Additional context

No response

[murali-shris]

@gkc @cpswan There seems to be a race condition(getKeys happens before save completes) in collections implementation. We are currently not using collections model in any of our apps. Temporarily commented collections test to unblock at_client release. I am downgrading the severity from P1 to P2.

[sitaram-kalluri]

The root cause of the test - "Model operations - unshare() and delete() test" failure is because there are two matching the regex, but the test expects only one key.

The following expects only one shared key which is sharedWith ce2e2 - expect(await fourthPhone.sharedWith(), ['@ce2e2']);; but the "getKeys" returns two shared keys (please refer to the screenshot attached) and the test fails with the below error.

Expected: ['@ce2e2'] Actual: ['@ce2e2', '@ce2e2'] Which: at location [1] is ['@ce2e2', '@ce2e2'] which longer than expected

The keys "ce2e2:123-personal-phone.phone.atcollectionmodel.buzz.wavi@ce2e1" and "ce2e2:personal-phone.phone.atcollectionmodel.buzz.wavi@ce2e1" are two shared keys returned.

To fix the issue, will generate a random number string and append to the id to make key unique for each run.