search

atsign-foundation / at_client_sdk

The Dart implementation of atSDK used for implementing Atsign's technology into other software
https://pub.dev/publishers/atsign.org/packages
BSD 3-Clause "New" or "Revised" License
1.47k stars 32 forks source link

ci: Use Docker Compose v2 #1282

Closed cpswan closed 3 months ago

cpswan commented 3 months ago

Fixes https://github.com/atsign-foundation/operations/issues/134 for this repo

- What I did

Modified scripts to use Docker Compose v2

- How I did it

s/docker-compose/docker compose/

- How to verify it

Functional tests

- Description for the changelog

ci: Use Docker Compose v2

cpswan commented 3 months ago

More joy - it seems that test_virtualenv_1 has been automangled to test-virtualenv-1

gkc commented 3 months ago

@cpswan I see Container test-virtualenv-1 Started in the "Start docker instance" job and No such container: test_virtualenv_1 in the "Run PKAM" job of the "functional_tests" workflow (link to action run)

Perhaps a backwards compatibility issue where previously underscores and hyphens were somehow treated the same way?

gkc commented 3 months ago

@cpswan I see Container test-virtualenv-1 Started in the "Start docker instance" job and No such container: test_virtualenv_1 in the "Run PKAM" job of the "functional_tests" workflow (link to action run)

Perhaps a backwards compatibility issue where previously underscores and hyphens were somehow treated the same way?

( I see you've already fixed it )

gkc commented 3 months ago

functional test run (beta) is good but the (stable) run looks like it's going to fail for an unrelated flakiness issue. Will re-run when it does

gkc commented 3 months ago

functional test run (beta) is good but the (stable) run looks like it's going to fail for an unrelated flakiness issue. Will re-run when it does

Didn't fail but took twice as long as the (beta) run. I'll copy the test run logs to take a look later if I have time.