search

atsign-foundation / at_client_sdk

The Dart implementation of atSDK used for implementing Atsign's technology into other software
https://pub.dev/publishers/atsign.org/packages
BSD 3-Clause "New" or "Revised" License
1.47k stars 32 forks source link

Make NotificationResponseTransformer respect atNotification.isEncrypted == false #1332

Open gkc opened 3 weeks ago

gkc commented 3 weeks ago

Describe the bug

If a client receives a notification where isEncrypted is explicitly false, it nonetheless continues to treat it as though isEncrypted were true

Steps to reproduce

Came across this bug when I was running an sshnpd with legacy atKeys at the same time as I was doing enroll requests; the enroll request notifications explicitly have isEncrypted == false (which is correct) but NotificationResponseTransformer nonetheless tries to decrypt the data and of course fails

Expected behavior

explicit isEncrypted == false should be respected

Additional context

See also https://github.com/atsign-foundation/at_server/issues/1944

gkc commented 1 week ago

Will work on this once this at_server PR has been merged and rolled out to prod