atsign-foundation / at_client_sdk

The Dart implementation of atSDK used for implementing Atsign's technology into other software
https://pub.dev/publishers/atsign.org/packages
BSD 3-Clause "New" or "Revised" License
1.47k stars 32 forks source link

fix: Export backupkey_contants and getEncryptedKeysMethod #1344

Closed sitaram-kalluri closed 1 week ago

sitaram-kalluri commented 2 weeks ago

- What I did

warning • The ability to import 'KeychainUtil' indirectly is deprecated • lib/services/backupkey_service.dart:13:18 • deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is deprecated • lib/services/backupkey_service.dart:19:22 • deprecated_export_use
warning • The ability to import 'BackupKeyConstants' indirectly is deprecated • test/backupkey_service_test.dart:130:24 • deprecated_export_use
warning • The ability to import 'BackupKeyConstants' indirectly is deprecated • test/backupkey_service_test.dart:137:24 • deprecated_export_use
warning • The ability to import 'BackupKeyConstants' indirectly is deprecated • test/backupkey_service_test.dart:144:24 • deprecated_export_use
warning • The ability to import 'BackupKeyConstants' indirectly is deprecated • test/backupkey_service_test.dart:151:24 • deprecated_export_use
warning • The ability to import 'BackupKeyConstants' indirectly is deprecated • test/backupkey_service_test.dart:156:24 • deprecated_export_use

The warnings are because "BackupKeyConstants" and "KeychainUtil" classes are present in the deprecated "at_client_service.dart" file, which has now been replaced by "AtAuthServiceImpl".

To resolve the lint warnings:

- How to verify it

~/IdeaProjects/atsign/widgets/at_widgets/packages/at_backupkey_flutter git:[fix_lint_issues_in_backupkey_flutter]
flutter analyze
Analyzing at_backupkey_flutter...                                       
No issues found! (ran in 2.0s)

Please refer to the following commit for the changes in the at_backupkey_flutter: https://github.com/atsign-foundation/at_widgets/compare/fix_lint_issues_in_backupkey_flutter

- Description for the changelog

gkc commented 1 week ago

Shouldn't AtClientService be marked as @Deprecated?

sitaram-kalluri commented 1 week ago

Shouldn't AtClientService be marked as @Deprecated?

The AtClientService is marked deprecated in at_client_mobile.dart, the changes are merged to trunk. Will also mark the class as deprecated in at_client_service.dart and push the changes.