atsign-foundation / at_client_sdk

The Dart implementation of atSDK used for implementing Atsign's technology into other software
https://pub.dev/publishers/atsign.org/packages
BSD 3-Clause "New" or "Revised" License
1.47k stars 32 forks source link

Chore: Imports used by some at_widget packages are depreciated #1346

Closed CurtlyCritchlow closed 6 days ago

CurtlyCritchlow commented 1 week ago

Describe the bug

The below warning messages appears on the following packages when using the dependency overrides for at_client_mobile:

dependency_overrides:
  at_client_mobile:
    git:
      url: https://github.com/atsign-foundation/at_client_sdk.git
      path: packages/at_client_mobile
      ref: expose_backupkey-constants

Warning Messages:

at_invitation_flutter

Analyzing at_invitation_flutter...                                      

   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService • example/lib/main.dart:36:3 •
          deprecated_member_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          example/lib/second_screen.dart:20:3 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • example/lib/second_screen.dart:20:3 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/invitation_service.dart:65:18 •
       deprecated_export_use

at_follows_flutter

Analyzing at_follows_flutter...                                        ⣾

   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService • lib/screens/connections.dart:21:9
          • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/screens/connections.dart:21:9 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/sdk_service.dart:25:24 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/sdk_service.dart:25:24 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is deprecated
       • lib/services/sdk_service.dart:35:18 • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/utils/at_follow_services.dart:16:7 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/utils/at_follow_services.dart:16:7 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          test/unit_tests/connections_service_test.dart:290:8 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • test/unit_tests/connections_service_test.dart:290:8
       • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          test/unit_tests/connections_service_test.dart:292:3 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • test/unit_tests/connections_service_test.dart:292:3
       • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          test/unit_tests/connections_service_test.dart:292:37 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • test/unit_tests/connections_service_test.dart:292:37
       • deprecated_export_use

at_location_flutter

Analyzing at_location_flutter...                                        

   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          example/lib/second_screen.dart:22:3 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is deprecated •
       example/lib/second_screen.dart:22:3 • deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is deprecated •
       lib/service/at_location_notification_listener.dart:75:18 • deprecated_export_use

at_login_flutter

Analyzing at_login_flutter

   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          example/lib/main.dart:35:3 • deprecated_member_use
warning • The ability to import 'KeychainUtil' indirectly is deprecated •
       lib/services/at_login_service.dart:197:29 • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          lib/widgets/at_login_widget.dart:35:30 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is deprecated •
       lib/widgets/at_login_widget.dart:35:30 • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          lib/widgets/at_login_widget.dart:100:30 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is deprecated •
       lib/widgets/at_login_widget.dart:100:30 • deprecated_export_use

at_onboarding_flutter

Analyzing at_onboarding_flutter...                                      

   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:24:16 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:24:16 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:25:17 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:25:17 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:68:3 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:68:3 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:72:5 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:72:5 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:72:31 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:72:31 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:94:5 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:94:5 •
       deprecated_export_use
   info • 'onboard' is deprecated and shouldn't be used. Use
          AtAuthService.onboard method •
          lib/services/onboarding_service.dart:96:49 •
          deprecated_member_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:128:7 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:128:7 •
       deprecated_export_use
   info • 'authenticate' is deprecated and shouldn't be used. Use
          AtAuthService.authenticate method •
          lib/services/onboarding_service.dart:133:52 •
          deprecated_member_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/onboarding_service.dart:157:12 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/onboarding_service.dart:162:12 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/onboarding_service.dart:167:12 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/onboarding_service.dart:172:41 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/sdk_service.dart:6:16 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/sdk_service.dart:6:16 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/sdk_service.dart:7:17 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/sdk_service.dart:7:17 •
       deprecated_export_use

at_theme_flutter

Analyzing at_theme_flutter...                                           

   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          example/lib/main.dart:40:3 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is deprecated • example/lib/main.dart:40:3 •
       deprecated_export_use
warning • The asset file '.env' doesn't exist • example/pubspec.yaml:68:7 • asset_does_not_exist

Steps to reproduce

  1. First I added the below dependency_overide to the pubspec.yaml file of the at_widget packages if they have at_client_mobile as a dependency.
dependency_overrides:
  at_client_mobile:
    git:
      url: https://github.com/atsign-foundation/at_client_sdk.git
      path: packages/at_client_mobile
      ref: expose_backupkey-constants
  1. Then I run flutter analyze in the teminal.

Expected behavior

They should be no info or warning messages about depreciated classes being imported directly.

Screenshots

No response

Smartphones

Were you using an atApplication when the bug was found?

at_theme_flutter, at_onboarding_flutter, at_login_flutter, at_location_flutter, at_follows_flutter, at_invitation_flutter

Additional context

No response

sitaram-kalluri commented 1 week ago

@CurtlyCritchlow : The lint issues and above mentioned packages are fixed. Please find the changes in the following commit: https://github.com/atsign-foundation/at_widgets/commit/32e396fc9b6e05922ea59c702e466dca29ba1eb3

CurtlyCritchlow commented 1 week ago

@sitaram-kalluri, I double check with flutter analyze and the issues have been resolved. Thanks