search

atsign-foundation / at_libraries

Support libraries & dependencies for Atsign's technology
https://pub.dev/publishers/atsign.org/packages
BSD 3-Clause "New" or "Revised" License
38 stars 11 forks source link

at_activate creates atKeys files but in the wrong place. (sshnp v5.5.0 binaries) #629

Closed cconstab closed 4 weeks ago

cconstab commented 1 month ago

Describe the bug

when creating a new request for keys the keyfil is created but in a subdirectory and not in the place it should.

Steps to reproduce

C
cconstab@orac:~$ at_activate enroll -s 9DWFF1  -p sshnp   -d orac_ssh_2  -n "sshnp:rw,sshrvd:rw" -a @ssh_1  --keys ~/.atsign/keys/@ssh_1_newkeys
Submitting enrollment request
Enrollment ID: 672e0d46-2e86-443e-8b79-be9d0078fca9
Waiting for approval; will check every 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  approved.
Creating atKeys file
[Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/@ssh_1_newkeys/.atKeys

Note [Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/@ssh_1_newkeys/.atKeys

This should I think read [Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/@ssh_1_newkeys.atKeys

Expected behavior

Keys created in the right place as requested

Screenshots

No response

Smartphones

Version : 5.5.0 (core: 6.1.0)

Were you using an atApplication when the bug was found?

No response

Additional context

No response

cconstab commented 3 weeks ago

Does this need to be pushed to pub dev? @sitaram-kalluri

sitaram-kalluri commented 3 weeks ago

Does this need to be pushed to pub dev? @sitaram-kalluri

@cconstab : Yes, we need to publish at_onboarding_cli package.

sitaram-kalluri commented 3 weeks ago

Tested the changes with noports by adding dependency_overrides for at_onboarding_cli to use git trunk branch and works as expected. Attaching the test log.

sitaram@sitaram-ThinkPad-E14:~/IdeaProjects/atsign/noports/packages/dart/sshnoports$ ./bin/at_activate enroll -s ABC123 -p myapp -d local -n "buzz:rw" -a @sitaram -r vip.ve.atsign.zone -k ~/keys/akam_keys/@sitaram_1_newkeys
Submitting enrollment request
Enrollment ID: dcebb3a6-6a3c-42dd-bce1-27f674605a6b
Waiting for approval; will check every 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  approved.
Creating atKeys file
[Success] Your .atKeys file saved at /home/sitaram/keys/akam_keys/@sitaram_1_newkeys.atKeys

Publishing the at_onboarding_cli package with version v 1.6.2 which will have the fix.