atsign-foundation / at_libraries

Support libraries & dependencies for Atsign's technology
https://pub.dev/publishers/atsign.org/packages
BSD 3-Clause "New" or "Revised" License
38 stars 11 forks source link

at_cli_onboarding does not create atKeys as expected #635

Closed cconstab closed 2 months ago

cconstab commented 2 months ago

Describe the bug

Seems that the library ignores/trims after a . in a atKey name

Steps to reproduce

  1. First get an OTP
  2. Enroll a key with a -K and ask for a key file with a . in the name
  3. Approve the enrollment
  4. atkey file created but trimmed (and possibly could over write?) to the first .
  5. example below

Expected behavior

use the key name asked for

Screenshots

[Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/orac.sshnp/.atKeys

cconstab@orac:~/twh$ ./at_activate enroll -s SIS1YC  -p sshnp   -d orac_subkey1  -n "orac.sshnp:rw,orac.sshrvd:rw" -a @ssh_1 --keys ~/.atsign/keys/orac.sshnp
Submitting enrollment request
Enrollment ID: 20347bcf-925b-438a-8124-13c70df5e0c5
Waiting for approval; will check every 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  approved.
Creating atKeys file
[Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/orac.atKeys

cconstab@orac:~/twh$ ./at_activate enroll -s 7IVW6H  -p sshnp   -d orac_subkey2  -n "orac.sshnp:rw,orac.sshrvd:rw" -a @ssh_1 --keys ~/.atsign/keys/oracsub2
Submitting enrollment request
Enrollment ID: 1625506f-8e54-4d67-ad33-fef71711d395
Waiting for approval; will check every 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  approved.
Creating atKeys file
[Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/oracsub2.atKeys

cconstab@orac:~/twh$

Smartphones

Were you using an atApplication when the bug was found?

No response

Additional context

No response

gkc commented 2 months ago

@sitaram-kalluri and/or @srieteja please can you pick this up?

sitaram-kalluri commented 2 months ago

@sitaram-kalluri and/or @srieteja please can you pick this up?

Sure Gary. I will work on this.