atsign-foundation / at_libraries

Support libraries & dependencies for Atsign's technology
https://pub.dev/publishers/atsign.org/packages
BSD 3-Clause "New" or "Revised" License
38 stars 11 forks source link

feat: add isEncrypted if set to false or true in notify command #649

Closed murali-shris closed 1 month ago

murali-shris commented 1 month ago

Fixes https://github.com/atsign-foundation/at_libraries/issues/650 - What I did

https://github.com/atsign-foundation/at_libraries/pull/646 https://github.com/atsign-foundation/at_server/pull/2087 https://github.com/atsign-foundation/at_client_sdk/pull/1393 https://github.com/atsign-foundation/at_libraries/pull/647 https://github.com/atsign-foundation/noports/pull/1344

murali-shris commented 1 month ago

This is fine as a stopgap. As a precaution, please add some unit tests re isEncrypted when using an UpdateVerbBuilder

https://github.com/atsign-foundation/at_libraries/pull/649/commits/141716aa9586faf49cdc04f2c18ad5a5695e4c8c Are these tests fine ?

murali-shris commented 1 month ago

I will rerun the tests once below PR is merged and then merge at_commons PR https://github.com/atsign-foundation/at_client_sdk/pull/1391