pkam support for different signing algorithms

atsign-foundation / at_server

The software implementation of Atsign's core technology

https://docs.atsign.com

BSD 3-Clause "New" or "Revised" License

39 stars 13 forks source link

pkam support for different signing algorithms #1202

Closed murali-shris closed 1 year ago

murali-shris commented 1 year ago

Is your feature request related to a problem? Please describe.

Currently private key is generated within the atsign app. Support for private keys in secure element like sim card

Describe the solution you'd like

change pkam verb syntax to support different signing algorithm
change pkam verb handler implementation to verify signature using ecdsa(new) and rsa256(existing)

Describe alternatives you've considered

No response

Additional context

No response

murali-shris commented 1 year ago

changes in at_commons https://github.com/atsign-foundation/at_server/issues/1202

murali-shris commented 1 year ago

at_commons v3.0.38 published with pkam syntax change to include signingAlgo and hashingAlgo

murali-shris commented 1 year ago

draft PR for server changes https://github.com/atsign-foundation/at_server/pull/1214

murali-shris commented 1 year ago

functional tests and manual testing complete. functional tests are failing in github actions since pkam public key has to be updated to secondary. @sitaram-kalluri is investigating the issue.

murali-shris commented 1 year ago

additional time spent for

checking github actions to see why pkam keys were not loaded in secondary
bug in ecc signing when atsign had emoji
changes in functional tests

murali-shris commented 1 year ago

Pull request https://github.com/atsign-foundation/at_server/pull/1214 merged to trunk