fix: Improve socket handling for better server resilience - Githubissues

atsign-foundation / at_server

The software implementation of Atsign's core technology

https://docs.atsign.com

BSD 3-Clause "New" or "Revised" License

39 stars 13 forks source link

fix: Improve socket handling for better server resilience #1859

Closed gkc closed 5 months ago

gkc commented 5 months ago

- What I did

Try to ensure that any async errors from sockets are not left unhandled (which will cause the server to exit). Similar changes have been made during the past year in the at_lookup and at_client packages
Partially addresses #1689

- How I did it

inbound_message_listener.dart: wrap call to 'listen' in runZonedGuarded; add StackTrace parameter to _errorHandler
outbound_message_listener.dart: wrap call to 'listen' in runZonedGuarded; add StackTrace parameter to _errorHandler
inbound_connection_impl.dart: simplify 'close' method and ensure that it always sets isClosed to true
outbound_connection_impl.dart: simplify 'close' method and ensure that it always sets isClosed to true

- How to verify it Tests pass