atsign-foundation / at_server

The software implementation of Atsign's core technology
https://docs.atsign.com
BSD 3-Clause "New" or "Revised" License
39 stars 13 forks source link

fix: Hive max length bug #1878

Closed murali-shris closed 3 months ago

murali-shris commented 3 months ago

fixes: https://github.com/atsign-foundation/at_server/issues/1863 - What I did

murali-shris commented 3 months ago

Should we restrict the length to 248 if it doesn't start with "cached:"? Leaves enough for a "cached:"prefix to be added on a caching atServer / client

sure Gary.

murali-shris commented 3 months ago

Should we restrict the length to 248 if it doesn't start with "cached:"? Leaves enough for a "cached:"prefix to be added on a caching atServer / client

sure Gary.

@gkc I had a discussion with @sitaram-kalluri on this. Let's say the key is @ bob: phone@ alice. This will be stored in alice's keystore. If the key has ttr, then @ bob will cache the key at his end. 255 char limit will be enforced at bob's keystore including cached: In persistence layer, 255 can be the max limit in client/server, 248 without cached: and 255 including cached: is this fine?

gkc commented 3 months ago

Should we restrict the length to 248 if it doesn't start with "cached:"? Leaves enough for a "cached:"prefix to be added on a caching atServer / client

sure Gary.

@gkc I had a discussion with @sitaram-kalluri on this. Let's say the key is @ bob: phone@ alice. This will be stored in alice's keystore. If the key has ttr, then @ bob will cache the key at his end. 255 char limit will be enforced at bob's keystore including cached: In persistence layer, 255 can be the max limit in client/server, 248 without cached: and 255 including cached: is this fine?

Yes I believe so