fix: OTP default expiry duration remain constant - Githubissues

atsign-foundation / at_server

The software implementation of Atsign's core technology

https://docs.atsign.com

BSD 3-Clause "New" or "Revised" License

39 stars 13 forks source link

fix: OTP default expiry duration remain constant #1955

Closed sitaram-kalluri closed 1 month ago

sitaram-kalluri commented 1 month ago

- What I did

Fix the following issue - "otpExpiryInMillis" is an instance variable and hence if the TTL is set, then the value remains for all the subsequent otp: verbs instead of the default expiry value.

- How I did it

Add "_defaultOtpExpiryInMills" and mark it as final to ensure its value is not changed.
Add the following logic - If TTL value is set, then set "otpExpiryInMills" to the value of TTL, else set to "_defaultOtpExpiryInMills".

- How to verify it

Added a unit test to ensure the default expiry of the OTP value not changed for the subsequent requests of the OTP.