feat: allow a ttl to be set for a semi-permanent passcode (spp) - Githubissues

atsign-foundation / at_server

The software implementation of Atsign's core technology

https://docs.atsign.com

BSD 3-Clause "New" or "Revised" License

39 stars 13 forks source link

feat: allow a ttl to be set for a semi-permanent passcode (spp) #1968

Closed gkc closed 1 month ago

gkc commented 1 month ago

- What I did feat: allow a ttl to be set for a semi-permanent passcode (spp)

- How I did it

feat: have AbstractVerbHandler.isOTPValid do an 'isActiveKey' check after fetching the SPP
feat: in the OtpVerbHandler 'put' block, use the ttl from the verb parameters if supplied, otherwise use -1
test: added unit tests covering the new behaviour

other changes

refactor: add a passcodeKey function to remove some code duplication
fix: change the UnauthenticatedException message in OtpVerbHandler from otp:get [...] to otp: [...]
refactor: change some variable names across 'put' and 'get' blocks in OtpVerbHandler for readability
refactor: add isSpp parameter to savePasscode and use savePasscode in OtpVerbHandler's 'put' block
refactor: rename isOTPValid to isPasscodeValid

- How to verify it Tests pass