fix: at_commons:4.0.1 uptake and increased pub points [at_onboarding_flutter]

atsign-foundation / at_widgets

Flutter widgets which aid in building applications using Atsign's technology

https://docs.atsign.com

BSD 3-Clause "New" or "Revised" License

52 stars 33 forks source link

fix: at_commons:4.0.1 uptake and increased pub points [at_onboarding_flutter] #800

Closed Sardar1208 closed 5 months ago

Sardar1208 commented 5 months ago

- What I did - updated all dependencies (including at_commons: 4.0.1) and fixed formatting at_commons ticket link - https://github.com/atsign-foundation/at_widgets/issues/794 pub points ticket - https://github.com/atsign-foundation/apps/issues/780

gkc commented 5 months ago

@sachins-geekyants Why was it OK to merge the PR even though the melos-bootstrap check failed?

Sardar1208 commented 5 months ago

@gkc The deps conflict shown here is not happening when we go a flutter pub get.

gkc commented 5 months ago

@gkc The deps conflict shown here is not happening when we go a flutter pub get.

OK ... would be good to know why the melos-bootstrap check is failing though

sachins-geekyants commented 5 months ago

melos-bootstrap issue was reproduced locally in at_contacts_flutter package because of at_common conflict between onboarding and contact_flutter package.

In next PR, these conflicts will be reolved.

cc: @gkc

gkc commented 5 months ago

melos-bootstrap issue was reproduced locally in at_contacts_flutter package because of at_common conflict between onboarding and contact_flutter package.

In next PR, these conflicts will be reolved.

cc: @gkc

Thanks @sachins-geekyants