search

atsign-foundation / at_widgets

Flutter widgets which aid in building applications using Atsign's technology
https://docs.atsign.com
BSD 3-Clause "New" or "Revised" License
53 stars 32 forks source link

`flutter analyze` failing on at_onboarding_flutter due to deprecation #843

Closed cpswan closed 4 months ago

cpswan commented 4 months ago

Which at_widget package you find issue with?

at_onboarding_flutter

On what platforms did you experience the issue?

Linux

What version are you using?

6.1.7

What happened?

During CI for #841 :

Analyzing at_onboarding_flutter...                              

   info • Use interpolation to compose strings and values • example/lib/contact_initial.dart:45:16 • prefer_interpolation_to_compose_strings
   info • The imported package 'at_onboarding_flutter' isn't a dependency of the importing package • example/lib/main.dart:4:8 • depend_on_referenced_packages
   info • The imported package 'path_provider' isn't a dependency of the importing package • example/lib/main.dart:6:8 • depend_on_referenced_packages
   info • Invalid use of a private type in a public API • example/lib/main.dart:32:3 • library_private_types_in_public_api
  error • The named parameter 'backgroundColor' isn't defined • example/lib/main.dart:58:13 • undefined_named_parameter
  error • The named parameter 'backgroundColor' isn't defined • example/lib/main.dart:68:13 • undefined_named_parameter
   info • Don't use 'BuildContext's across async gaps • example/lib/main.dart:113:27 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps • example/lib/main.dart:152:27 • use_build_context_synchronously
   info • The 'child' argument should be last in widget constructor invocations • example/lib/main.dart:180:33 • sort_child_properties_last
   info • The 'child' argument should be last in widget constructor invocations • example/lib/main.dart:182:33 • sort_child_properties_last
   info • Don't use 'BuildContext's across async gaps • example/lib/main.dart:224:17 • use_build_context_synchronously
   info • The imported package 'at_onboarding_flutter' isn't a dependency of the importing package • example/lib/switch_atsign.dart:2:8 • depend_on_referenced_packages
   info • Invalid use of a private type in a public API • example/lib/switch_atsign.dart:21:3 • library_private_types_in_public_api
  error • The getter 'backgroundColor' isn't defined for the type 'ThemeData' • example/lib/switch_atsign.dart:48:42 • undefined_getter
   info • Don't use 'BuildContext's across async gaps • example/lib/switch_atsign.dart:69:37 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • example/lib/switch_atsign.dart:83:49 • use_build_context_synchronously
  error • The getter 'bodyText1' isn't defined for the type 'TextTheme' • example/lib/switch_atsign.dart:104:68 • undefined_getter
   info • Don't use 'BuildContext's across async gaps • lib/at_onboarding.dart:58:9 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps • lib/screen/at_onboarding_activate_screen.dart:147:9 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_activate_screen.dart:158:23 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_home_screen.dart:820:9 • use_build_context_synchronously
   info • The declaration '_showQRCodeScreen' isn't referenced • lib/screen/at_onboarding_home_screen.dart:847:8 • unused_element
   info • The declaration '_uploadQRFileForDesktop' isn't referenced • lib/screen/at_onboarding_home_screen.dart:955:16 • unused_element
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_otp_screen.dart:359:30 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_otp_screen.dart:371:28 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_pair_screen.dart:259:38 • use_build_context_synchronously
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:59:30 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:61:30 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:62:20 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:107:30 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:110:17 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:111:20 • deprecated_member_use

32 issues found. (ran in 16.2s)

Steps to reproduce

1. Go to packages/at_onboarding_flutter
2. Run `flutter analyze` with latest Flutter

Additional info

@srieteja like with #842 I've assigned you as the most likely person to be able to fix this, but please shout if you think it should be somebody else.

Relevant log output

No response

Flutter analyze output

Analyzing at_onboarding_flutter...                              

   info • Use interpolation to compose strings and values • example/lib/contact_initial.dart:45:16 • prefer_interpolation_to_compose_strings
   info • The imported package 'at_onboarding_flutter' isn't a dependency of the importing package • example/lib/main.dart:4:8 • depend_on_referenced_packages
   info • The imported package 'path_provider' isn't a dependency of the importing package • example/lib/main.dart:6:8 • depend_on_referenced_packages
   info • Invalid use of a private type in a public API • example/lib/main.dart:32:3 • library_private_types_in_public_api
  error • The named parameter 'backgroundColor' isn't defined • example/lib/main.dart:58:13 • undefined_named_parameter
  error • The named parameter 'backgroundColor' isn't defined • example/lib/main.dart:68:13 • undefined_named_parameter
   info • Don't use 'BuildContext's across async gaps • example/lib/main.dart:113:27 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps • example/lib/main.dart:152:27 • use_build_context_synchronously
   info • The 'child' argument should be last in widget constructor invocations • example/lib/main.dart:180:33 • sort_child_properties_last
   info • The 'child' argument should be last in widget constructor invocations • example/lib/main.dart:182:33 • sort_child_properties_last
   info • Don't use 'BuildContext's across async gaps • example/lib/main.dart:224:17 • use_build_context_synchronously
   info • The imported package 'at_onboarding_flutter' isn't a dependency of the importing package • example/lib/switch_atsign.dart:2:8 • depend_on_referenced_packages
   info • Invalid use of a private type in a public API • example/lib/switch_atsign.dart:21:3 • library_private_types_in_public_api
  error • The getter 'backgroundColor' isn't defined for the type 'ThemeData' • example/lib/switch_atsign.dart:48:42 • undefined_getter
   info • Don't use 'BuildContext's across async gaps • example/lib/switch_atsign.dart:69:37 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • example/lib/switch_atsign.dart:83:49 • use_build_context_synchronously
  error • The getter 'bodyText1' isn't defined for the type 'TextTheme' • example/lib/switch_atsign.dart:104:68 • undefined_getter
   info • Don't use 'BuildContext's across async gaps • lib/at_onboarding.dart:58:9 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps • lib/screen/at_onboarding_activate_screen.dart:147:9 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_activate_screen.dart:158:23 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_home_screen.dart:820:9 • use_build_context_synchronously
   info • The declaration '_showQRCodeScreen' isn't referenced • lib/screen/at_onboarding_home_screen.dart:847:8 • unused_element
   info • The declaration '_uploadQRFileForDesktop' isn't referenced • lib/screen/at_onboarding_home_screen.dart:955:16 • unused_element
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_otp_screen.dart:359:30 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_otp_screen.dart:371:28 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check • lib/screen/at_onboarding_pair_screen.dart:259:38 • use_build_context_synchronously
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:59:30 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:61:30 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:62:20 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:107:30 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:110:17 • deprecated_member_use
   info • 'MaterialStateProperty' is deprecated and shouldn't be used. Use WidgetStateProperty instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre • lib/widgets/at_onboarding_button.dart:111:20 • deprecated_member_use

32 issues found. (ran in 16.2s)


### Flutter doctor output

_No response_