search

atsign-foundation / at_widgets

Flutter widgets which aid in building applications using Atsign's technology
https://docs.atsign.com
BSD 3-Clause "New" or "Revised" License
53 stars 32 forks source link

chore: Clear Up Info Messages for at_widget packages using flutter 3.23 beta channel #860

Closed CurtlyCritchlow closed 3 months ago

CurtlyCritchlow commented 3 months ago

- What I did closes #859 - How I did it Run flutter analyze to see info message. Make the changes to clear the info message - How to verify it Github static analyser should run successfully. - Description for the changelog

Clear up info messages

CurtlyCritchlow commented 3 months ago

@cpswan One of the check failed. This because onPopInvokedWithResult is the replacement method on the flutter 3.23 beta for onPopInvoked but onPopInvokedWithResult is not available on the stable channel. I'll have to revert to onPopInvoked but this will be the only info message on the beta channel.

cpswan commented 3 months ago

OK @CurtlyCritchlow

Can we put an annotation in place to supress that info message, and an issue to remind us to make the change once it lands in stable.

Breaking changes > Generic types in PopScope for reference.

CurtlyCritchlow commented 3 months ago

@cpswan I'm about to inbox you about a strategy for publishing the new versions of our packages. I didn't update the dependencies as yet because in some cases it cause conflicts due to other at_widgets packages that are dependencies using older versions and not the newer versions.