search

atsign-foundation / atsign.dev

This repo is no longer in use -> Navigate to docs.atsign.com to view most up-to-date code.
https://devstaging.atsign.wtf
BSD 3-Clause "New" or "Revised" License
19 stars 30 forks source link

Showcase doesn't render correctly in desktop #435

Closed yahu1031 closed 2 years ago

yahu1031 commented 2 years ago

Describe the bug Footer is being hidden(looks like) due to the showcase cards.

Screenshots

https://user-images.githubusercontent.com/35523357/156650594-53c40beb-0b0b-4403-a987-2067ea5e4a7c.mp4

Smartphone (please complete the following information):

How to resolve this

amanbedi1 commented 2 years ago

Can you assign it to me I can do it

TylerTrott commented 2 years ago

Can you assign it to me I can do it

Assigned

vermaayush680 commented 2 years ago

Hi @TylerTrott can you assign it to me. I have found the issue and would like to work on it.

Bikramjit21 commented 2 years ago

Can anyone assign me?

vermaayush680 commented 2 years ago

Hi @TylerTrott, Fixed the Showcase footer issue. Let me know if it's fine and I'll make a PR for it. https://user-images.githubusercontent.com/42459801/157077485-9b19b7e5-3f42-4bef-8867-135eefb62e6c.mp4

Also here is the mobile view https://user-images.githubusercontent.com/42459801/157078130-56f8688b-1103-476b-9d3b-34625024b254.mp4