Closed gkc closed 3 months ago
@gkc what is holding this PR back?
@gkc what is holding this PR back?
@XavierChanth as per notes in the PR description : Nothing, now that the other PR has been approved, other than I need to a) merge it, b) publish new version of at_onboarding_cli, c) update the at_onboarding_cli dependency here, d) have it reviewed again and then e) merged. I'll do all of that in the morning
@gkc what is holding this PR back?
@XavierChanth as per notes in the PR description : Nothing, now that the other PR has been approved, other than I need to a) merge it, b) publish new version of at_onboarding_cli, c) update the at_onboarding_cli dependency here, d) have it reviewed again and then e) merged. I'll do all of that in the morning
Have done all of that.
- What I did For e2e tests:
- How I did it
- How to verify it e2e tests pass