fix: sshnp: various arg parsing issues

[gkc]

- What I did Fixes #1046

- How I did it

• make parsing of integer options fail if a non-parseable value is supplied
• if --device is not supplied, print a warning message stating that, and mentioning that it will be mandatory in future
• assert that argParser.rest is empty after parsing, since we are capturing all parameters via options or flags
• test: fix a test which had extraneous arguments in its command-line and was now failing due to the argParser.rest assertion we added

- How to verify it Tests pass

[gkc]

If we're not changing --device to mandatory then LGTM.

This PR does change it to mandatory see sshnp_arg.dart file diff

[gkc]

We cannot make device mandatory, it will break the ability to use list-devices, it instead should be validated similar to how --from and --to are.

  // models/sshnp_params.dart:274

  factory SshnpParams.fromPartial(SshnpPartialParams partial) {
    // Always need the clientAtSign
    partial.clientAtSign ??
        (throw ArgumentError('from (clientAtSign) is mandatory'));

    if (!(partial.listDevices ?? DefaultSshnpArgs.listDevices)) {
      // if list-devices is not set, then ensure sshnpdAtSign and srvdAtSign are set
      partial.sshnpdAtSign ??
          (throw ArgumentError(
              'Option to is mandatory, unless list-devices is passed.'));
      partial.srvdAtSign ??
          (throw ArgumentError(
              'srvdAtSign is mandatory, unless list-devices is passed.'));
    }

    return SshnpParams(
      profileName: partial.profileName,
      clientAtSign: partial.clientAtSign!,
      sshnpdAtSign: partial.sshnpdAtSign ?? "",
      srvdAtSign: partial.srvdAtSign ?? "",
      device: partial.device ?? DefaultSshnpArgs.device,
      ...
);

@XavierChanth ack

[gkc]

@XavierChanth as per your comment on #1046 I've reverted the change to make --device mandatory and instead am outputting a warning from the sshnp CLI if device is "default"

[XavierChanth]

What I should have probably done from the start is make list-devices a subcommand instead of a flag. We can change it in v6, which will then allow us to enforce the arguments (I think... args is not the most flexible package)

[gkc]

@XavierChanth There's a flurry of PRs right now so I'll need to rerun the e2e_all check before I merge, but those tests are working fine