search

atsign-foundation / noports

Connect to any device with no external listening ports open
https://noports.com
BSD 3-Clause "New" or "Revised" License
263 stars 15 forks source link

feat: No double ssh when sockets encrypted #1090

Closed gkc closed 1 month ago

gkc commented 1 month ago

- What I did Closes #990

- How I did it See commits

- How to verify it Tests pass

XavierChanth commented 1 month ago

@gkc pushed a minor change, the C daemon will return null for the ephemeral ssh key in the payload, so I made sure to only assert that the ephemeral key is not null when encryptTraffic = false.

gkc commented 1 month ago

@XavierChanth Shall we merge this to trunk?

XavierChanth commented 1 month ago

@XavierChanth Shall we merge this to trunk?

Yes, I think we can, I've not encountered any further issues.