atsign-foundation / noports

Connect to any device with no external listening ports open
https://noports.com
BSD 3-Clause "New" or "Revised" License
263 stars 15 forks source link

C daemon - incorrect help text for `--permit-open=<str>` #1101

Closed cpswan closed 1 month ago

cpswan commented 1 month ago

Describe the bug

sshnpd --help shows Manager to use (mandatory) alongside the --permit-open=<str> flag:

Usage:
Version : 0.1.0

    --help                        show this help message and exit
    -k, --key-file=<str>          Path to the key file
    -a, --atsign=<str>            Atsign to use (mandatory)
    -m, --manager=<str>           Manager to use (mandatory)
    -d, --device=<str>            Device to use
    -s, --sshpublickey            Generate ssh public key
    -h, --hide                    Hide device from device entry (still responds to pings)
    -v, --verbose                 Verbose output
    --permit-open=<str>           Manager to use (mandatory)
    --ssh-algorithm=<str>         SSH algorithm to use
    --ephemeral-permission=<str>  Ephemeral permission to use
    --root-domain=<str>           Root domain to use
    --local-sshd-port=<int>       Local sshd port to use

Steps to reproduce

  1. First I run ./sshnpd --help
  2. Then I look at the output

Expected behavior

Shows help info for that flag

XavierChanth commented 1 month ago

This should be fixed in my latest commit