search

atsign-foundation / noports

Connect to any device with no external listening ports open
https://noports.com
BSD 3-Clause "New" or "Revised" License
267 stars 15 forks source link

bug (c sshnpd): list-devices not showing C daemon devices #1115

Closed XavierChanth closed 2 months ago

XavierChanth commented 3 months ago
XavierChanth commented 3 months ago

There's a file called background_jobs.c, the puts in that file are showing up when I scan with at-repl, but when I sshnp -f @<client> --ls they don't show up.

XavierChanth commented 3 months ago

Also related to the same function: username is not being shared to the client.

JeremyTubongbanua commented 3 months ago

I can pick this up this sprint (PR90)

Will also try to fix the issue where atclient_atkey memory is allocated in the fork'd thread that is not cleared

XavierChanth commented 3 months ago

Thanks, yeah maybe we pre-allocate that memory in the main thread so it can be freed there instead. However one caveat, this memory is not constant size, it is proportional to the number of managers which can be found in the sshnpd_params struct.

JeremyTubongbanua commented 3 months ago

o it can be freed there instead. However one caveat, this memory is not constant size, it is proportional to the number of ma

Thanks 👍🏼 I was thinking of pre-allocating the memory before entering the thread..