atsign-foundation / noports

Connect to any device with no external listening ports open
https://noports.com
BSD 3-Clause "New" or "Revised" License
267 stars 15 forks source link

fix: C SSHNPD memory leaks before SSH connection established #1135

Closed JeremyTubongbanua closed 3 months ago

JeremyTubongbanua commented 3 months ago

- What I did

- How to verify it

valgrind leak summary after starting daemon, pkam authenticating, starting main loop, then Ctrl-C

==194277== LEAK SUMMARY:
==194277==    definitely lost: 0 bytes in 0 blocks
==194277==    indirectly lost: 0 bytes in 0 blocks
==194277==      possibly lost: 0 bytes in 0 blocks
==194277==    still reachable: 0 bytes in 0 blocks
==194277==         suppressed: 223 bytes in 1 blocks
JeremyTubongbanua commented 3 months ago

As of most recent commit of sending this message,

C SSHNPD works with at_c commit hash: 977cf8f51bb93e494b14fedfe3a577f440e45f0e

JeremyTubongbanua commented 3 months ago

Will wait for https://github.com/atsign-foundation/at_c/pull/325 to be pushed to trunk before we push this to trunk

JeremyTubongbanua commented 3 months ago

Will do 1 more pass before I merge @XavierChanth