search

atsign-foundation / noports

Connect to any device with no external listening ports open
https://noports.com
BSD 3-Clause "New" or "Revised" License
263 stars 15 forks source link

fix: make sure necessary directories exist #1139

Closed gkc closed 2 weeks ago

gkc commented 2 weeks ago

- What I did fix: make LocalSshKeyUtil constructor (1) create, if they don't already exist, any directories that are expected to exist and (2) set strict directory permissions Fixes #1138

- How I did it

- How to verify it Tests pass

gkc commented 2 weeks ago

@cpswan @cconstab can you build sshnpd from this branch and verify it resolves #1138 please?

cconstab commented 2 weeks ago

Will do when I land

cpswan commented 2 weeks ago

Confirmed that the fix works.

In terms of releasing I'd suggest that we don't do a 5.3.1, but rather just move ahead with 5.4.0

We can add to the 5.3.0 release a note saying that the .sshnp directory needs to be created if not present

cconstab commented 2 weeks ago

Perfect.. Thanks to you both.. Perhaps also worth having a test for this so we do not regress again too.